Re: row filtering for logical replication

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Euler Taveira <euler(at)eulerto(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication
Date: 2021-09-15 08:47:54
Message-ID: CAHut+PuWPHKg4t2MkXbwv6MMZHbxZ0_E47X1_q=iXV4==tWnEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Euler,

FYI - the last-known-good "main" patch has been broken in the cfbot
for the last couple of days due to a recent commit [1] on the HEAD.

To keep the cfbot happy I have re-based it.

In this same post (so that they will not be misplaced and so they
remain working with HEAD) I am also re-attaching all of my currently
pending "incremental" patches. These are either awaiting merge back
into the "main" patch and/or they are awaiting review.

~

PSA 5 patches:

v29-0001 = the latest "main" patch (was
v28-0001-Row-filter-for-logical-replication.patch from [2]) is now
rebased to HEAD.

v29-0002 = my tab auto-complete patch (was
v1-0001-Add-tab-auto-complete-support-for-the-Row-Filter-.patch from
[3]) awaiting merge.

v29-0003 = my cache updates patch (was
v26-0002-ExprState-cache-modifications.patch from [4]) awaiting merge.

v29-0004 = my filter validation replica identity patch (was
v28-0002-Row-filter-validation-replica-identity.patch from [5])
awaiting review/merge.

v29-0005 = my filter validation walker POC patch (was
v28-0003-POC-row-filter-walker-validation.patch from [6]) awaiting
feedback.

~

It is getting increasingly time-consuming to maintain and track all
these separate patches. If possible, please merge them back into the
"main" patch.

------
[1] https://github.com/postgres/postgres/commit/1882d6cca161dcf9fa05ecab5abeb1a027a5cfd2
[2] https://www.postgresql.org/message-id/CAHut%2BPv-Gz_bA6djDOnTz0OT-fMykKwidsK6bLDU5mZ1KWX9KQ%40mail.gmail.com
[3] https://www.postgresql.org/message-id/CAHut%2BPsi7EygLemHnQbdLSZhBqyxqHY-3Mov1RS5xFAR%3Dxg-wg%40mail.gmail.com
[4] https://www.postgresql.org/message-id/CAHut%2BPsgRHymwLhJ9t3By6%2BKNaVDzfjf6Y4Aq%3DJRD-y8t1mEFg%40mail.gmail.com
[5] https://www.postgresql.org/message-id/CAHut%2BPukNh_HsN1Au1p9YhG5KCOr3dH5jnwm%3DRmeX75BOtXTEg%40mail.gmail.com
[6] https://www.postgresql.org/message-id/CAHut%2BPt6%2B%3Dw7_r%3DCHBCS%2ByZXk5V%2BtnrzHLi3b2ZOVP1LHL2W9w%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v29-0002-PS-Add-tab-auto-complete-support-for-the-Row-Fil.patch application/octet-stream 2.2 KB
v29-0005-PS-POC-Row-filter-validation-walker.patch application/octet-stream 11.9 KB
v29-0003-PS-ExprState-cache-modifications.patch application/octet-stream 11.4 KB
v29-0004-PS-Row-filter-validation-of-replica-identity.patch application/octet-stream 20.1 KB
v29-0001-Row-filter-for-logical-replication.patch application/octet-stream 70.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-09-15 08:50:12 Re: Hook for extensible parsing.
Previous Message tanghy.fnst@fujitsu.com 2021-09-15 08:06:37 Remove double check when field_name is not NULL in be-secure-openssl.c