| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Yuchen Li <liyuchen_xyz(at)163(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+ |
| Date: | 2026-04-23 00:34:27 |
| Message-ID: | CAHut+PuNme3=6LTj9ap-bew5WnVVsZ-W8ccQiUwkYqHd+WpVqQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 22, 2026 at 9:27 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Apr 21, 2026 at 12:16 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > PSA v4, now combined as Vignesh suggested, and with the extra space also fixed.
> >
>
> I would like to explicitly mention in the commit message that "Tag for
> included publications was a pre-existing behavior but it is better to
> change it for making it consistent with excluded publications tag. So,
> how about a commit message as follows: "psql: Improve describe footer
> titles for publications.
>
> The psql describe (`\d`) footer titles were previously unintuitive
> when listing publications that included or excluded specific tables.
> Even though the tag for included publications was pre-existing, it is
> better to update it to "Included in publications:" to match the
> phrasing of the "Excluded from publications:" tag.
>
> Footer titles for sequence and schema descriptions have been updated
> similarly to maintain consistency."
>
> --
OK, but the order what happened was a bit different.
1/ Firstly, it was only the "Except publications:" footer for \d that
was unintuitive. So that was updated to "Excluded from publications:".
2/ The pre-existing "Publications:" was intuitive as-is, but it was
updated to better match wording of 1.
3/ Then footer titles for sequence/schema were updated same
So maybe reword it slightly something like below:
SUGGESTION
The psql describe (`\d`) footer title was previously unintuitive when listing
publications that excluded specific tables. This has been fixed to say
"Excluded from publications:".
The pre-existing footer title for listing publications that include specific
tables has also been modified to to better match that phrasing. Now it says
"Included in publications:".
Footer titles for sequence and schema descriptions have been updated
similarly to maintain consistency.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-04-23 01:04:07 | Re: RFC: pg_stat_logmsg |
| Previous Message | Chao Li | 2026-04-23 00:03:08 | Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal |