| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add lookup table for replication slot invalidation causes |
| Date: | 2024-02-22 06:19:36 |
| Message-ID: | CAHut+PuNMJJ3Y3UwxrZP8Nh6=iJ5ABHJGrLTNOTP59n-xdLLcQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Sorry for the late comment but isn't the pushed logic now
different to what it was there before?
IIUC previously (in a non-debug build) if the specified
conflict_reason was not found, it returned RS_INVAL_NONE -- now it
seems to return whatever enum happens to be last.
How about something more like below:
----------
ReplicationSlotInvalidationCause
GetSlotInvalidationCause(const char *conflict_reason)
{
ReplicationSlotInvalidationCause cause;
bool found = false;
for (cause = 0; !found && cause <= RS_INVAL_MAX_CAUSES; cause++)
found = strcmp(SlotInvalidationCauses[cause], conflict_reason) == 0;
Assert(found);
return found ? cause : RS_INVAL_NONE;
}
----------
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-02-22 06:30:08 | Re: Add lookup table for replication slot invalidation causes |
| Previous Message | Kyotaro Horiguchi | 2024-02-22 05:40:05 | Re: About a recently-added message |