| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Yuchen Li <liyuchen_xyz(at)163(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+ |
| Date: | 2026-04-21 06:45:58 |
| Message-ID: | CAHut+Pu3401UyW+qO-P3BcdxzwwL+wwb_ROpYNsHvJ427nWJkQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 20, 2026 at 6:50 PM Yuchen Li <liyuchen_xyz(at)163(dot)com> wrote:
>
> On 4/20/2026 2:46 PM, Peter Smith wrote:
> >>> PSA v3 patches.
> >>>
> >>> v3-0001 - Fixed the TABLE describe footer titles as suggested.
> >>> - "Included in publications:"
> >>> - "Excluded from publications:"
> >>>
> >>> v3-0002 - Made similar footer title changes for SEQUENCE describe
> >>>
> >>> v3-0003 - Made similar footer title changes for SHCEMA describe. In
> >>> passing, I found that this \dn describe output was not even being
> >>> tested, so I added the missing regression test.
> >> I'm not sure separate patches are necessary for this change; it might
> >> be better to merge them into a single patch. Other than that, the
> >> changes look good.
> >>
> > I separated them because only the changes to TABLE \d had previously
> > been discussed.
> >
> > If everyone thinks all changes are good, then I can combine them into one patch.
> >
> > ======
> > Kind Regards,
> > Peter Smith.
> > Fujitsu Australia.
> >
> While reviewing 0003, I noticed a formatting issue in the following line:
>
> + * schema mapping count + 1 (for storing NULL).
>
> There is an extra space after "count +".
>
PSA v4, now combined as Vignesh suggested, and with the extra space also fixed.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-describe-footer-titles.patch | application/octet-stream | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-04-21 06:51:55 | Re: DOCS: typo on CLUSTER page |
| Previous Message | John Naylor | 2026-04-21 06:45:46 | Re: [PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION |