| From: | Yuchen Li <liyuchen_xyz(at)163(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+ |
| Date: | 2026-04-20 08:49:35 |
| Message-ID: | 4ff427ca-7986-4d13-820f-199672ab81ff@163.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/20/2026 2:46 PM, Peter Smith wrote:
>>> PSA v3 patches.
>>>
>>> v3-0001 - Fixed the TABLE describe footer titles as suggested.
>>> - "Included in publications:"
>>> - "Excluded from publications:"
>>>
>>> v3-0002 - Made similar footer title changes for SEQUENCE describe
>>>
>>> v3-0003 - Made similar footer title changes for SHCEMA describe. In
>>> passing, I found that this \dn describe output was not even being
>>> tested, so I added the missing regression test.
>> I'm not sure separate patches are necessary for this change; it might
>> be better to merge them into a single patch. Other than that, the
>> changes look good.
>>
> I separated them because only the changes to TABLE \d had previously
> been discussed.
>
> If everyone thinks all changes are good, then I can combine them into one patch.
>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia.
>
While reviewing 0003, I noticed a formatting issue in the following line:
+ * schema mapping count + 1 (for storing NULL).
There is an extra space after "count +".
Regards,
Yuchen Li
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-04-20 08:54:47 | Re: [PATCH] Reject ENCODING option for COPY TO FORMAT JSON |
| Previous Message | Dean Rasheed | 2026-04-20 08:42:31 | Re: Bug: Rule actions see wrong values for generated columns (NEW.gen reads OLD value) |