Re: Corrected documentation of data type for the logical replication message formats.

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Corrected documentation of data type for the logical replication message formats.
Date: 2021-05-09 13:13:58
Message-ID: CAHut+PtiPO4WJ_CH65aKv1A2V4-V-3jDuhKjDTwAEVcN_O4K0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 9, 2021 at 10:38 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Hi,
>
> For some of the logical replication messages the data type documented
> was not correct, especially for lsn and xid. For lsn actual datatype
> used is uint64 but is documented as int64, similarly for xid, datatype
> used is uint32 but documented as int32.
> Attached is a patch which has the fix for the same.
> Thoughts?

If you want to do this then there are more - e.g. Flags should be
Uint8 instead of Int8.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2021-05-09 13:23:14 Re: Corrected documentation of data type for the logical replication message formats.
Previous Message Yura Sokolov 2021-05-09 12:57:22 Re: plan with result cache is very slow when work_mem is not enough