Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables.

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables.
Date: 2026-10-20 04:02:27
Message-ID: CAHut+Pte1xRBxPZd_QQRnfqV4dvrS-ZLQqQN1BBX+VKHB2CE4A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 20, 2026 at 1:16 PM Takeshi Ideriha
<iderihatakeshi(at)gmail(dot)com> wrote:
>
> Hi all
>
> > Thanks for your review comments. I agree with you.
> >
> > PSA patch v2, which also fixes the misleading "never" wording in the
> > original sentence.
>
> Thank you for creating another thread per my suggestion.
> The patch V2 looks good to me.
>
> It's completely optional but I noticed that ALTER PUBLICATION doc [1]
> also mentions ONLY and '*' though ALTER PUBLICATION doc does not mention
> partitioned table at all. How about adding the similar note to ALTER
> doc? I know the main purpose of this patch is to remove ambiguous
> sentence from CREATE PUBLICATION doc. But it could be worthwhile to
> clarify how postgres behaves also in ALTER doc.
>

Hi Takeshi-San

Sure, I guess it makes sense for those paragraphs in CREATE and ALTER
to say the same thing.

(At least, it is easier to make them the same than to justify why they
shouldn't be.)

PSA v3.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v3-0001-DOCS-Remove-ambiguous-wording-about-ONLY-for-part.patch application/octet-stream 2.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Takeshi Ideriha 2026-10-20 04:19:50 Re: doc: Document Linux cgroup memory limits
Previous Message Fujii Masao 2026-10-20 04:01:09 Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables.