| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | surya poondla <suryapoondla4(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables. |
| Date: | 2026-11-05 20:56:02 |
| Message-ID: | CAHut+PtZA+MzY3=E4LXDfMwB+8SrpuTcS2xszRPZqTJcnXCUzA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 28, 2026 at 7:16 AM surya poondla <suryapoondla4(at)gmail(dot)com> wrote:
>
>
> Hi Peter,
>
> Thanks for v4. Splitting the patch makes sense.
>
> 0001 looks good to me.
>
> 0002 also looks good to me. "For a partitioned table, ONLY and * have no
> effect." is accurate for every ALTER PUBLICATION variant, and since
> it no longer frames this in terms of adding, it addresses my concern
> about DROP.
>
> I agree the DROP TABLE p * behavior with explicitly-added partitions
> is a separate question from this docs patch. If anyone wants to pursue it, a separate thread is the right place.
>
> Both patches apply cleanly on master.
>
> Regards,
> Surya Poondla
Thanks. AFAIK, this CF entry [1] can now be marked as "Ready for
Committer", unless somebody has more review comments?
======
[1] https://commitfest.postgresql.org/patch/7482/
Kind Regards,
Peter Smith
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-11-05 21:00:19 | Re: Custom oauth validator options |
| Previous Message | Peter Smith | 2026-11-05 20:45:08 | Re: BUG? Unpublished generated columns are reported "missing" by the subscription |