Re: Redundant/mis-use of _(x) gettext macro?

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
Date: 2026-06-11 22:57:33
Message-ID: CAHut+Pt2L5jAS2qXDENa2-+0dX2gH+kFWQbfkE3uzCoSRrjGFA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 12, 2026 at 2:44 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Apr-24, Peter Smith wrote:
>
> > OK. Including the comma within a larger translated string seems like a
> > better idea.
> [...]
> > Also, why did you choose to implement `last` versus `first` logic?
> > e.g. How about this?
>
> In the end I decided to go with the flow and changed to use "first"
> logic rather than "last". I also figured that we should change the
> other two places you pointed out at the start of the thread to use the
> same coding style. Since this is mostly cosmetic, I don't feel
> compelled to back-patch it, and pushed only to master.
>

Thanks for pushing!

> Another place I noticed while looking this over is psql's
> describeOneTableDetails(), per the attached patch. It's essentially
> more of the same, but arguably different enough that I judged it
> warranted posting before pushing.
>

This additional patch LGTM.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-06-11 23:12:14 CI failure: postgres_fdw_get_connections
Previous Message Michael Paquier 2026-06-11 22:33:13 Re: A trivial fix on a comment in pgstat_assoc_relation()