| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skipping schema changes in publication |
| Date: | 2026-04-01 03:55:53 |
| Message-ID: | CAHut+PsXKQbyAhQLRHX0aANkJZPWsYpz4TQQba1WFM7dvSwXNg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 1, 2026 at 1:15 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Apr 1, 2026 at 6:13 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
...
> > Hi Vignesh.
> >
> > Thanks for following up on my outstanding review comments.
> >
> > //////
> > Patch 0001 - Fix few issues in commit fd366065e0
> >
> > This did not address the review comment 3a about the redundant macro
> > '_("\"%s\"")', but that one might be better handled in a separate
> > thread anyway. I can post a separate thread for that one later.
> >
>
> Yes, as it uses an existing code as an example, it is better to start
> a separate thread. I was planning to do some research by myself after
> finishing the pending tasks here but feel free to start if you have
> formed your thoughts on it.
>
New thread for this is here [1].
Kind Regards,
Peter Smith.
Fujitsu Australia.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-04-01 03:57:00 | Re: Redundant/mis-use of _(x) gettext macro? |
| Previous Message | Peter Smith | 2026-04-01 03:48:08 | Redundant/mis-use of _(x) gettext macro? |