Re: Remove unused arguments from split_selfjoin_quals()

Miłosz Bieniek <bieniek(dot)milosz(at)proton(dot)me> 于2026年8月27日周四 18:21写道：
> I think `root` argument was introduced in [1] to do an assertion,
> but that assertion was removed shortly after being added.
> `from` and `to` on the other hand were introduced in [2],
> but weren't used from the start.
>
> LGTM!
>
> [1] https://www.postgresql.org/message-id/CAKJS1f8cJOCGyoxi7a_LG7eu%2BWKF9%2BHTff3wp1KKS5gcUg2Qfg%40mail.gmail.com
> [2] https://www.postgresql.org/message-id/c97574c4-13e6-9107-26ab-af2bd626fc85%40postgrespro.ru
>

Thanks, Miłosz, for the review and the historical details.

While looking through the SJE code again, I noticed that the "root"
argument of match_unique_clauses() is also unused. Attached is v2,
which removes that argument in addition to the three unused arguments
of split_selfjoin_quals() covered by the original patch.

There is no functional change.

--
Thanks,
Tender Wang