From ca9c4ec1076c1a432c0388f90e0d6dcbb24a7e43 Mon Sep 17 00:00:00 2001 From: Tender Wang Date: Wed, 19 Aug 2026 14:35:38 +0800 Subject: [PATCH] Remove unused arguments from split_selfjoin_quals() The root, from, and to arguments of split_selfjoin_quals() are not used by the function. In particular, from and to are also inconsistent with the remove/keep terminology used by the surrounding self-join elimination code. Remove these unused arguments to simplify the function interface. --- src/backend/optimizer/plan/analyzejoins.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/backend/optimizer/plan/analyzejoins.c b/src/backend/optimizer/plan/analyzejoins.c index 87a5d9d58b8..ebc9a0925e9 100644 --- a/src/backend/optimizer/plan/analyzejoins.c +++ b/src/backend/optimizer/plan/analyzejoins.c @@ -2226,8 +2226,8 @@ remove_self_join_rel(PlannerInfo *root, PlanRowMark *kmark, PlanRowMark *rmark, * itself. */ static void -split_selfjoin_quals(PlannerInfo *root, List *joinquals, List **selfjoinquals, - List **otherjoinquals, int from, int to) +split_selfjoin_quals(List *joinquals, List **selfjoinquals, + List **otherjoinquals) { List *sjoinquals = NIL; List *ojoinquals = NIL; @@ -2462,8 +2462,7 @@ remove_self_joins_one_group(PlannerInfo *root, Relids relids) * other quals. e.g., "x = x" goes to selfjoinquals and "a = b" to * otherjoinquals. */ - split_selfjoin_quals(root, restrictlist, &selfjoinquals, - &otherjoinquals, rrel->relid, krel->relid); + split_selfjoin_quals(restrictlist, &selfjoinquals, &otherjoinquals); Assert(list_length(restrictlist) == (list_length(selfjoinquals) + list_length(otherjoinquals))); -- 2.43.0