| From: | David Christensen <david(at)pgguru(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: [PATCH] GROUP BY ALL |
| Date: | 2025-09-28 19:18:48 |
| Message-ID: | CAHM0NXgP6-a75XgAR-WdKfzvDRcUv3=CipR+Zt2qmZ0T8bcABg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 27, 2025 at 5:23 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Here's a v6 that's rebased up to HEAD and contains fixes for the
> semantic issues we discussed. It still lacks documentation, but
> otherwise I think it's about ready to go.
Here is v7 with a stab at docs; fairly minimal at this point, but
touching the two areas that are likely to need adjusting. When
adjusting the docs for sql-select, I noticed that the grammar also
supports `GROUP BY ALL <grouping_elements>`, so I also added a test to
ensure that this syntax is explicitly supported. (It seems like it
works as-is without further grammar adjustments, but I was a little
worried when I first saw that fact... :D) Not sure that
aggregates.sql is still the right place for all of these bits, but it
does seem like having all things `GROUP BY ALL`-related tested in the
same place is a nice property, so leaving there for now.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2025-09-28 20:34:28 | Re: [PATCH] GROUP BY ALL |
| Previous Message | Álvaro Herrera | 2025-09-28 16:54:23 | Re: allow benign typedef redefinitions (C11) |