Re: Addition of %b/backend_type in log_line_prefix of TAP test logs

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Addition of %b/backend_type in log_line_prefix of TAP test logs
Date: 2025-05-21 02:41:18
Message-ID: CAHGQGwHy+QNJw6bYWFa0fLb7smpmARfqv51vJ0BX8DHRaqsd_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 21, 2025 at 8:51 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Hi all,
>
> While navigating through the logs in the CI, the buildfarm, or even my
> own machine, I've found myself spending a lot of time looking at
> very specific log entries to find out the PID of a specific process,
> sometimes mistaking a normal backend vs a logical WAL sender while
> looking for a PID, or just looking for an auxiliary process.
>
> I'd like to suggest the following change in Cluster.pm:
> - print $conf "log_line_prefix = '%m [%p] %q%a '\n";
> + print $conf "log_line_prefix = '%m [%b,%p] %q%a '\n";

+1 to this change.

Since pg_regress uses log_line_prefix = '%m %b[%p] %q%a ',
isn't it better to use the same setting in TAP tests as well?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-05-21 02:45:24 Re: Minor adjustment to pg_aios output naming
Previous Message torikoshia 2025-05-21 02:14:11 Minor adjustment to pg_aios output naming