Minor adjustment to pg_aios output naming

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Minor adjustment to pg_aios output naming
Date: 2025-05-21 02:14:11
Message-ID: 6df1e949d1d759ad2767c18e5845963e@oss.nttdata.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I've noticed a minor inconsistency in the output of pg_aios.

According to the documentation, the values for 'operation' are described
as:

<literal>readv</literal>, a vectored read
...
<literal>writev</literal>, a vectored write

However, in actual output, they appear as read and write -- without the
trailing v:

=# select operation from pg_aios;
..
operation | read

While this discrepancy is unlikely to cause any real issues, it would be
better to keep the naming consistent.

I was a bit unsure which form to align to.
There are currently no other types of read/write operations in pg_aios,
so the shorter form might have been sufficient.
However, using the 'v'-suffixed names makes the vectored nature of these
operations explicit and future-proofs
the naming in case other variants are introduced later.

What do you think?

Best regards,

--
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.

Attachment Content-Type Size
v1-0001-Adjust-pg_aios-operation-names-to-match-documenta.patch text/x-diff 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-05-21 02:41:18 Re: Addition of %b/backend_type in log_line_prefix of TAP test logs
Previous Message Michael Paquier 2025-05-21 01:28:00 Re: Regression in statement locations