| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Fix psql tab completion for REPACK boolean options |
| Date: | 2026-05-18 04:17:13 |
| Message-ID: | CAHGQGwHhBvDj=cyko-zdeEVtpCTvXNOESsLZCYsCB0C50T-unQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 15, 2026 at 11:32 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > Second, when the same option is specified multiple times, the last value
> > is not always honored. In particular, if any occurrence sets an option to ON,
> > the option remains enabled even when the final setting is OFF.
> >
> > I think these are bugs, and the attached patch fixes them. Thoughts?
>
> I agree that these are bugs. The patch looks good to me on a cursory
> look, though I didn't actually test it.
Thanks for the review! I've tested it again and then pushed it.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-05-18 04:19:02 | Re: Fix small issues of pg_restore_extended_stats() |
| Previous Message | Tatsuo Ishii | 2026-05-18 03:45:51 | Re: Should IGNORE NULLS cache nullness for volatile arguments? |