| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Fix psql tab completion for REPACK boolean options |
| Date: | 2026-05-15 14:32:14 |
| Message-ID: | agbx4dodnrsG9NZy@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-May-15, Fujii Masao wrote:
> BTW, while testing REPACK boolean options, I found two other issues
> in their parsing.
>
> First, REPACK (CONCURRENTLY OFF) failed with:
>
> ERROR: unrecognized REPACK option "concurrently"
>
> even though REPACK (CONCURRENTLY ON) works correctly. That is,
> CONCURRENTLY was treated as an unrecognized option when disabled.
Oh :-(
> Second, when the same option is specified multiple times, the last value
> is not always honored. In particular, if any occurrence sets an option to ON,
> the option remains enabled even when the final setting is OFF.
>
> I think these are bugs, and the attached patch fixes them. Thoughts?
I agree that these are bugs. The patch looks good to me on a cursory
look, though I didn't actually test it.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Nathan Bossart | 2026-05-15 14:06:09 | Re: [PATCH] refint: Avoid reusing cascade UPDATE plans. |