Re: Deadlock detector fails to activate on a hot standby replica

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Deadlock detector fails to activate on a hot standby replica
Date: 2026-06-25 12:14:20
Message-ID: CAHGQGwHejDzesOd_VFfwJdrWUqKbsvPf6cuTWJuuKs3t7tN+vQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 25, 2026 at 12:16 AM Vitaly Davydov
<v(dot)davydov(at)postgrespro(dot)ru> wrote:
>
> Dear Fujii Masao
>
> I've prepared patches of v6 for other majors. I hope, it will help.

Thanks for the patches for the stable branches!

I noticed that you added "buf_state &= ~BM_PIN_COUNT_WAITER;" to
BufferIsReadyForCleanup(). Could you tell me why that's necessary? My
understanding was that LockBufferForCleanup() is responsible for
clearing that flag, so I didn't think it was needed here.

But if it is necessary, I'd like to make the same change in master as
well, to keep the code as consistent as possible between master and
the stable branches.

> I will also think of a better approach for tap-test patch as well.

Thanks!

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Maxime Schoemans 2026-06-25 12:19:09 Re: [PATCH] btree_gist: add cross-type integer operator support for GiST
Previous Message Xuneng Zhou 2026-06-25 11:58:29 Re: [PATCH] Prevent repeated deadlock-check signals in standby buffer pin waits