| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Rintaro Ikeda <ikedarintarof(at)oss(dot)nttdata(dot)com> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "slpmcf(at)gmail(dot)com" <slpmcf(at)gmail(dot)com>, "boekewurm+postgres(at)gmail(dot)com" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Date: | 2025-10-28 16:00:25 |
| Message-ID: | CAHGQGwHcyBduDS_5NEUdJSpAy0imvOjTK2ebDO-uWOc8uiKMbg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 27, 2025 at 6:13 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> One approach to address this issue is to keep calling PQgetResult() until
> it returns NULL, and then check the connection status when getSQLErrorStatus()
> determines the error state. If the connection status is CONNECTION_BAD
> at that point, we can treat it as a connection failure and stop processing
> even when --continue-on-error is specified. Attached is a WIP patch
> implementing this idea based on the v17 patch. It still needs more testing,
> review, and possibly documentation updates.
>
> Another option would be to explicitly list all SQLSTATE codes (e.g., 57P01)
> that should prevent continued processing, even with --continue-on-error,
> inside getSQLErrorStatus(). However, maintaining such a list would be
> cumbersome, so I believe the first approach is preferable. Thought?
Nagata-san let me know off-list that there was the case where the previous
patch didn't work correctly in pipeline mode. I've updated the patch so that
--continue-on-error now works properly in that mode, and also revised
the commit message. Updated patch attached.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v19-0001-pgbench-Add-continue-on-error-option.patch | application/octet-stream | 18.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2025-10-28 16:41:37 | Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions |
| Previous Message | Dimitrios Apostolou | 2025-10-28 15:31:16 | Re: [PING] fallocate() causes btrfs to never compress postgresql files |