| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Manu <manuelreyesbravo(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, shihao zhong <zhong950419(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: [PG19] Promotion hangs behind a backend blocked on a stuck client |
| Date: | 2026-10-15 16:56:01 |
| Message-ID: | CAHGQGwH_S-q2SrOoUPoKTpMy_FVpnm4WBVekioehan2xB4W8pA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 15, 2026 at 3:51 PM Manu <manuelreyesbravo(at)gmail(dot)com> wrote:
> The wait isn't needed when the new status is "off" either: a process
> still caching "on" only writes extra logical info, which is safe, the
> same reasoning DisableLogicalDecoding() already uses to emit without
> waiting.
0003 looks good to me. I've attached an updated version with revised
comments in UpdateLogicalDecodingStatusEndOfRecovery(), which still
claimed that all processes had updated their XLogLogicalInfo state
before the function returned.
I think it's better to backpatch this to v19, since commit 67c20979ce7
introduced the unnecessary barrier wait. Thoughts?
Barring any objections, I'm thinking to commit it.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v3-0001-Avoid-unnecessary-end-of-recovery-barrier-waits.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-10-15 17:32:48 | Re: doc: fix pg_get_multixact_stats() num_mxids type (integer -> bigint) |
| Previous Message | Naga Appani | 2026-10-15 16:53:24 | Re: doc: fix pg_get_multixact_stats() num_mxids type (integer -> bigint) |