| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Manu <manuelreyesbravo(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, shihao zhong <zhong950419(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: [PG19] Promotion hangs behind a backend blocked on a stuck client |
| Date: | 2026-10-15 17:40:06 |
| Message-ID: | CAD21AoACzNhrRkvRLa=vRyabRUH1XOTKZ1TsTGuyYm3KogvHiw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 15, 2026 at 9:56 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Oct 15, 2026 at 3:51 PM Manu <manuelreyesbravo(at)gmail(dot)com> wrote:
> > The wait isn't needed when the new status is "off" either: a process
> > still caching "on" only writes extra logical info, which is safe, the
> > same reasoning DisableLogicalDecoding() already uses to emit without
> > waiting.
>
> 0003 looks good to me. I've attached an updated version with revised
> comments in UpdateLogicalDecodingStatusEndOfRecovery(), which still
> claimed that all processes had updated their XLogLogicalInfo state
> before the function returned.
>
> I think it's better to backpatch this to v19, since commit 67c20979ce7
> introduced the unnecessary barrier wait. Thoughts?
>
> Barring any objections, I'm thinking to commit it.
Thank you for the patch. It looks good to me, and I agree that it
should be backpatched to v19.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-10-15 17:46:11 | Re: Unlogged materialized views |
| Previous Message | Fujii Masao | 2026-10-15 17:32:48 | Re: doc: fix pg_get_multixact_stats() num_mxids type (integer -> bigint) |