Re: BUG #19631: currtid2() on a view with GROUP BY ctid crashes with XX000

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Cc: Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19631: currtid2() on a view with GROUP BY ctid crashes with XX000
Date: 2026-11-20 15:43:36
Message-ID: CAHGQGwHKboO2hfxJaxXZJRGv4xOqG7Nw5XQdUOTAS9-SO-7_0w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Sun, Sep 13, 2026 at 12:50 AM Ayush Tiwari
<ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> I've added it for now, but personally I don't think it is required.

I agree that the additional test isn't necessary here.

- (errmsg("Unicode categorization can only be performed if server
encoding is UTF8")));
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("Unicode categorization can only be performed if server
encoding is UTF8")));

unicode_norm_form_from_string() and str_casefold() have similar encoding
checks, but use ERRCODE_SYNTAX_ERROR. I think
ERRCODE_FEATURE_NOT_SUPPORTED is more appropriate, so I'd keep it here.
Should we change those two checks to use it too?

if (!crc_ok)
ereport(ERROR,
- (errmsg("calculated CRC checksum does not match value stored in file")));
+ (errcode(ERRCODE_DATA_CORRUPTED),
+ errmsg("calculated CRC checksum does not match value stored in file")));

perform_base_backup() has the same control-file CRC check without
an errcode(). Should we add ERRCODE_DATA_CORRUPTED there as well?

> (PS. This patch is intended for master only)

+1

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rui Zhao 2026-11-20 15:47:45 Re: [PATCH v2] Fix SP-GiST index-only scans that return only INCLUDE columns
Previous Message Virender Singla 2026-11-20 15:40:29 Re: Allow pg_read_all_stats to read replication origin status

Browse pgsql-bugs by date

  From Date Subject
Previous Message yuansong 2026-11-20 15:37:56 [PATCH v1] Fix stale composite type OIDs in cached PL/pgSQL expressions