| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19631: currtid2() on a view with GROUP BY ctid crashes with XX000 |
| Date: | 2026-09-12 15:50:02 |
| Message-ID: | CAJTYsWVoc0Gx0m_ocJKhvcJ2=6V_q=JHXwF9-dJvnGBvg402nA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Hi,
Thanks for the review!
On Sat, 12 Sept 2026 at 14:46, Pierre Forstmann
<pierre(dot)forstmann(at)gmail(dot)com> wrote:
>
> I think that the that SQLSTATE chosen in unicode_assigned() is wrong: this not a SQL statement syntax error but more a feature not supported for the current database encoding;
> ERRCODE_FEATURE_NOT_SUPPORTED is more appropriate.
Hmm, you are right, added that instead.
> Maybe you could add a regression test for tid.c ?
I've added it for now, but personally I don't think it is required.
(PS. This patch is intended for master only)
Attached v2.
Regards,
Ayush
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-internal-errors-reachable-from-SQL.patch | application/octet-stream | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Motiani | 2026-09-12 15:50:26 | Re: BUG #19681: ILIKE rejected on nondeterministic collations while LIKE works |
| Previous Message | Andrey Rachitskiy | 2026-09-12 14:22:32 | Re: BUG #19633: Unexpected results of IN (subquery) with a non-deterministic collation |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Aidar Imamov | 2026-09-12 15:44:43 | Re: meson: pass OpenSSL/ICU include dirs to extensions |