| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Invalid primary_slot_name triggers warnings in all processes on reload |
| Date: | 2025-10-22 13:31:22 |
| Message-ID: | CAHGQGwHJxhaQQ7bf_wPBYBTJO+X+rK_-znsgay_kYm2ncJYAGQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 22, 2025 at 12:52 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> So let's push the current patch, including only the cosmetic indentation
> changes suggested by Hayato-san.
I've pushed the patch. Thanks!
Attached is the rebased version of the patch I shared earlier, which adds
GUC_check_errmsg_internal(), GUC_check_errdetail_internal(),
and GUC_check_errhint_internal(). These functions work like
their counterparts (e.g., GUC_check_errmsg()) but skip translation.
The patch also updates the check hook for primary_slot_name to use
these new functions when handling already-translated error messages.
If we apply this patch, I'm thinking to push it to master only.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Avoid-double-translation-of-messages-for-invalid-.patch | application/octet-stream | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-10-22 13:32:03 | Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc? |
| Previous Message | Akshay Joshi | 2025-10-22 13:21:50 | Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement |