From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Invalid primary_slot_name triggers warnings in all processes on reload |
Date: | 2025-10-22 03:52:07 |
Message-ID: | CAHGQGwEGN4qW=FDCKpHTOBLbV9kgm=DNQFZNFp5cVotvcikvoA@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Oct 21, 2025 at 7:27 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Oct 21, 2025 at 2:36 PM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > > Just to confirm - you'd prefer backpatching errhint_internal() to v17 and
> > > earlier branches, and then updating the patch to use it to avoid double
> > > translation, right?
> >
> > Exactly, but I want to ask other Seniors as well.
> >
>
> I don't think it is important enough to backpatch errhint_internal to
> v17 and earlier branches. We can let double translation happen with
> the use of errhint or we can even consider this as a HEAD only
> improvement because this is not a blocking issue even when it happens.
+1
So let's push the current patch, including only the cosmetic indentation
changes suggested by Hayato-san. *If* we later reach consensus on
backpatching errhint_internal(), we can handle that separately.
Since another patch [1] seems to depend on this one, it's better not to
delay committing it.
Regards,
[1] https://postgr.es/m/CAA5-nLCeO4MQzWipCXH58qf0arruiw0OeUc1+Q=Z=4GM+=v1NQ@mail.gmail.com
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | AIX PG user | 2025-10-22 03:52:39 | Re: AIX support |
Previous Message | Tatsuo Ishii | 2025-10-22 03:14:11 | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |