| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small fixes about backup history file in doc and pg_standby |
| Date: | 2018-06-26 15:58:18 |
| Message-ID: | CAHGQGwHJ7u2mm6yOiSdXK09O2wvhtDM2xhtjYa2d7eV1j0_o2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 26, 2018 at 5:47 PM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> Hi,
>
> While looking into the backup and recovery code, I found small documentation bugs.
> The documatation says that the backup history files can be requested for recovery,
> but it's not used by the system and not requested anymore since PG 9.0
> (commit 06f82b29616cd9effcaefd99c6b6e2e80697482f) and never be requested.
>
> Attached patch (doc_backup_history_file.patch) corrects the description about this.
Pushed. Thanks!
> In addition, the current pg_standby still can handle a backup history file that are
> never requested. It is harmless but unnecessary code. Another attached patch
> (pg_standby.patch) removes this part of code.
Since this is not bug fix, let's discuss this in 12dev cycle.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Zakirov | 2018-06-26 15:59:18 | Re: ALTER TABLE does not check for column existence before starting operations |
| Previous Message | Robert Haas | 2018-06-26 15:53:53 | Re: "wal receiver" process hang in syslog() while exiting after receiving SIGTERM while the postgres has been promoted. |