From: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Small fixes about backup history file in doc and pg_standby |
Date: | 2018-06-27 08:42:07 |
Message-ID: | 20180627174207.d8744c56.nagata@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 27 Jun 2018 00:58:18 +0900
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Jun 26, 2018 at 5:47 PM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> > Hi,
> >
> > While looking into the backup and recovery code, I found small documentation bugs.
> > The documatation says that the backup history files can be requested for recovery,
> > but it's not used by the system and not requested anymore since PG 9.0
> > (commit 06f82b29616cd9effcaefd99c6b6e2e80697482f) and never be requested.
> >
> > Attached patch (doc_backup_history_file.patch) corrects the description about this.
>
> Pushed. Thanks!
Thanks!
>
> > In addition, the current pg_standby still can handle a backup history file that are
> > never requested. It is harmless but unnecessary code. Another attached patch
> > (pg_standby.patch) removes this part of code.
>
> Since this is not bug fix, let's discuss this in 12dev cycle.
Certainly.
Regards,
>
> Regards,
>
> --
> Fujii Masao
>
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
From | Date | Subject | |
---|---|---|---|
Next Message | Yugo Nagata | 2018-06-27 08:52:53 | Re: Small fixes about backup history file in doc and pg_standby |
Previous Message | Michael Paquier | 2018-06-27 08:29:38 | Re: PANIC during crash recovery of a recently promoted standby |