| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | "wang(dot)xiao(dot)peng" <wxp_728(at)163(dot)com>, lukas(at)fittl(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hannu Krosing <hannuk(at)google(dot)com> |
| Subject: | Re: pg_test_timing: fix unit typo and widen diff type |
| Date: | 2026-04-22 16:11:53 |
| Message-ID: | CAHGQGwHFHghHRn1427m_ZH_D9t0gytKRa96Uid-pJ4VyZCvyOw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 22, 2026 at 5:58 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> PFA v4:
>
> * 0001 unchanged from v3.
> * 0002 changed size of histogram[] 64.
Thanks for updating the patch!
Since patch 0001 is a bug fix, it should be backpatched to the supported stable
branches. However, in v19 the unit should be changed like s/ms/ns, while in v18
and earlier s/ms/us, since those older branches report the diff in microseconds.
Right?
Patch 0002 looks more like an improvement than a bug fix, so we should probably
wait for the next CommitFest before committing it. Thoughts?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-04-22 16:19:26 | Fix DROP PROPERTY GRAPH "unsupported object class" error |
| Previous Message | vignesh C | 2026-04-22 16:03:22 | Re: StringInfo fixes, v19 edition. Plus a few oddities |