Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers
Date: 2026-11-04 13:37:18
Message-ID: CAHGQGwHCxZ_aTmf3b3FRac_C_muuH=U+2cC4_WruY0=tVYgP5A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 4, 2026 at 7:46 PM Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
> Just for my
> understanding: why use ReScanExprContext instead of ResetExprContext here?

Yeah, since AFAICT there seems no need to invoke registered callbacks,
ResetExprContext() might be sufficient. Also, ResetPerTupleExprContext()
would be better for consistency with CopyFrom(), which uses it?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-11-04 13:53:57 Re: pg_get_*_ddl() needs a redesign
Previous Message Andres Freund 2026-11-04 13:33:57 Re: Avoid using raw xmin of frozen tuples in logicalrep conflict detection