Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers
Date: 2026-11-04 15:26:54
Message-ID: 33976e8a-43f8-4e5d-b175-f5d9f08cd043@uni-muenster.de
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/11/2026 14:37, Fujii Masao wrote:
> Yeah, since AFAICT there seems no need to invoke registered callbacks,
> ResetExprContext() might be sufficient. Also, ResetPerTupleExprContext()
> would be better for consistency with CopyFrom(), which uses it?
>

IIUC es_per_tuple_exprcontext will always be non-NULL because of
GetPerTupleExprContext(), so in theory the extra check in
ResetPerTupleExprContext() is a bit redundant, but I agree it's a good
idea to keep the code consistent.

Thanks!

Best, Jim

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-11-04 15:33:23 Re: [PATCH] Add recovery boundary WAL record for database and tablespace commands
Previous Message shihao zhong 2026-11-04 14:59:38 Re: Hash index corruption and CLOG lookup errors from checkpoint races