| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
| Cc: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: REPACK is missing from the MAINTAIN privilege documentation |
| Date: | 2026-07-16 04:46:26 |
| Message-ID: | CAHGQGwH7Er3K0qiGLnU-JvoM4o2CtsqXNC78ff0y1vt9p9g7Tw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 16, 2026 at 7:36 AM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
>
> On Wed, Jul 15, 2026 at 6:55 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote
> > It's also better to update the following source comment in aclchk.c.
> >
> > /*
> > * Check if ACL_MAINTAIN is being checked and, if so, and not already set
> > * as part of the result, then check if the user is a member of the
> > * pg_maintain role, which allows VACUUM, ANALYZE, CLUSTER, REFRESH
> > * MATERIALIZED VIEW, REINDEX, and LOCK TABLE on all relations.
> > */
> > if (mask & ACL_MAINTAIN &&
> > !(result & ACL_MAINTAIN) &&
> > has_privs_of_role(roleid, ROLE_PG_MAINTAIN))
> > result |= ACL_MAINTAIN;
>
> Good catch, thanks! I've updated the patch as you said.
Thanks for updating the patch! I've pushed it.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2026-07-16 04:54:23 | Re: Improve pg_stat_statements scalability |
| Previous Message | shveta malik | 2026-07-16 04:45:41 | Re: Support EXCEPT for TABLES IN SCHEMA publications |