| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: REPACK is missing from the MAINTAIN privilege documentation |
| Date: | 2026-07-15 22:35:48 |
| Message-ID: | CAOzEurTeBUhucTFp_mHPBkhg9AJNomNhDx8RBx-5KXLQbjp4wg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 15, 2026 at 6:55 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote
> It's also better to update the following source comment in aclchk.c.
>
> /*
> * Check if ACL_MAINTAIN is being checked and, if so, and not already set
> * as part of the result, then check if the user is a member of the
> * pg_maintain role, which allows VACUUM, ANALYZE, CLUSTER, REFRESH
> * MATERIALIZED VIEW, REINDEX, and LOCK TABLE on all relations.
> */
> if (mask & ACL_MAINTAIN &&
> !(result & ACL_MAINTAIN) &&
> has_privs_of_role(roleid, ROLE_PG_MAINTAIN))
> result |= ACL_MAINTAIN;
Good catch, thanks! I've updated the patch as you said.
--
Best regards,
Shinya Kato
NTT OSS Center
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-doc-Add-REPACK-to-the-list-of-commands-allowed-by.patch | application/octet-stream | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-07-15 22:51:55 | Re: VS 2026 support on old branches |
| Previous Message | Tom Lane | 2026-07-15 22:25:23 | Re: Small patch to improve safety of utf8_to_unicode(). |