| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: file_fdw: Support multi-line HEADER option. |
| Date: | 2026-01-21 07:38:58 |
| Message-ID: | CAHGQGwH3PJ8an=Z-70s3Nv=YY3btAJ=qD76Tivh2XgnABq8Xmg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 21, 2026 at 12:07 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Jan-20, Fujii Masao wrote:
>
> > I'm thinking to commit the attached patches.
>
> In 0001 I would recommend to move the string "match" to outside the
> message. Otherwise a translator might be tempted to translate it, and
> then it would make no sense. (I have never seen this happen in
> Postgres, but I have seen this kind of translation mistake in other
> software, and it is infuriating.)
Thanks for the review!
Agreed. I've updated the patches as suggested.
The revised versions are attached.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0002-file_fdw-Support-multi-line-HEADER-option.patch | application/octet-stream | 13.1 KB |
| v6-0001-Improve-the-error-message-in-COPY-with-HEADER-opt.patch | application/octet-stream | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2026-01-21 07:47:33 | Re: Optional skipping of unchanged relations during ANALYZE? |
| Previous Message | jian he | 2026-01-21 07:37:00 | Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row |