Re: file_fdw: Support multi-line HEADER option.

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: file_fdw: Support multi-line HEADER option.
Date: 2026-01-20 15:07:43
Message-ID: 202601201506.yrmcvqjl2bnc@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Jan-20, Fujii Masao wrote:

> I'm thinking to commit the attached patches.

In 0001 I would recommend to move the string "match" to outside the
message. Otherwise a translator might be tempted to translate it, and
then it would make no sense. (I have never seen this happen in
Postgres, but I have seen this kind of translation mistake in other
software, and it is infuriating.)

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Los minutos y los segundos son mercadería de la ciudad, donde un infeliz se
afana por no perder ni siquiera un segundo y no advierto que obrando de ese
modo pierde una vida." ("La vuelta de Don Camilo", G. Guareschi)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2026-01-20 15:39:10 Re: Adding REPACK [concurrently]
Previous Message Jelte Fennema-Nio 2026-01-20 15:03:59 Re: enable fallthrough warnings on clang