| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Date: | 2025-11-21 16:14:04 |
| Message-ID: | CAHGQGwGnkM8aYtxYAHXRPWYe90fbypz5TMezHDiy0Jt8=+BPpQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 21, 2025 at 6:24 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> No, what I was thinking is that, we could combine the three set statement into one, like:
>
> ```
> Set a = 1; set b = 2; set c = 3;
> ```
> So that sends a single statement to publisher server, that reduces round-trip from 3 times to one time.
I see the point about combining the three SET commands to reduce round trips,
but I think the current approach in the patch (i.e., issuing a separate
SET command for each parameter) is sufficient. I still don't think
the additional round trip during replication connection startup is
a real concern. This approach is also consistent with what postgres_fdw
and pg_dump already do.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-11-21 16:16:21 | Re: change default default_toast_compression to lz4? |
| Previous Message | Tom Lane | 2025-11-21 16:10:47 | Re: more C99 cleanup |