Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date: 2025-11-21 09:23:10
Message-ID: 6E35E0EF-A842-408A-A264-DB6D428C2BD6@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 21, 2025, at 15:47, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
>>
>> 4. The commit message:
>> ```
>> This commit removes the restriction by changing how logical replication
>> connections are established so that GUC settings in the CONNECTION string
>> are properly passed through to and uesd by the walsender. This enables
>> ```
>>
>> This is a little bit inaccurate, all user specified settings expected the 3 ones being overwritten will be honored.
>
> Are you suggesting that, because datestyle and the other two parameters
> specified in CONNECTION aren(t actually applied by the walsender,
> the commit message should explicitly mention that not all parameters
> from CONNECTION are used?

No, what I was thinking is that, we could combine the three set statement into one, like:

```
Set a = 1; set b = 2; set c = 3;
```
So that sends a single statement to publisher server, that reduces round-trip from 3 times to one time.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2025-11-21 09:46:13 Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB barriers
Previous Message shveta malik 2025-11-21 09:10:14 Re: Improve pg_sync_replication_slots() to wait for primary to advance