| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> | 
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> | 
| Cc: | Karina Litskevich <litskevichkarina(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> | 
| Subject: | Re: doc: Improve description of io_combine_limit and io_max_combine_limit GUCs | 
| Date: | 2025-10-30 13:31:33 | 
| Message-ID: | CAHGQGwGfPzcin-_6XwPgVbWTOUFVZgHF5g9ROrwLUdCTfjy=0A@mail.gmail.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On Mon, Oct 13, 2025 at 10:33 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> On Oct 13, 2025, at 19:33, Karina Litskevich <litskevichkarina(at)gmail(dot)com> wrote:
>
> On Thu, Oct 9, 2025 at 6:05 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
> So, this patch looks good to me. Please any committer takes care of this patch.
>
>
> Thank you for the review!
>
> Could you please change the status of the commitfest entry [1] to
> Ready for Commiter if you believe it's ready?
>
> [1] https://commitfest.postgresql.org/patch/6115/
>
>
> Done.
The patch looks good to me.
I also noticed another issue in the io_max_combine_limit docs.
Since its context is PGC_POSTMASTER, shouldn't the following
description be updated to say "This parameter can only be set at server start"?
         This parameter can only be set in
         the <filename>postgresql.conf</filename> file or on the server
         command line.
Regards,
-- 
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mats Kindahl | 2025-10-30 13:32:45 | Re: Coccinelle for PostgreSQL development [1/N]: coccicheck.py | 
| Previous Message | Peter Eisentraut | 2025-10-30 13:30:56 | Re: Mark ItemPointer arguments as const thoughoutly |