| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Date: | 2025-11-25 11:30:35 |
| Message-ID: | CAHGQGwGaXJO5iYOX+DDV1ZLH22r0TE1N8O-KOWNZQ2z6ndN0hA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 24, 2025 at 12:52 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> V3 looks good to me.
Thanks for reviewing the patch!
> > Yeah, I agree that if certain GUCs can break logical replication,
> > we should enforce "safe" values, just as we currently do for datestyle.
> > And if any other GUCs can cause the issue, they could affect
> > postgres_fdw etc, so the fix would need to be broader.
>
> Just want to clarify if you mean you will handle this in a future patch?
I don't currently know of any other parameters that must be forced for
logical replication or postgres_fdw. But if we identify any, I'm happy to
review a patch that adds the necessary handling.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-11-25 11:32:51 | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Previous Message | Soumya S Murali | 2025-11-25 11:28:49 | Re: Checkpointer write combining |