Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

On Mon, Nov 24, 2025 at 2:55 PM Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>
> On Fri, Nov 21, 2025, 00:47 Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> On Thu, Nov 20, 2025 at 3:54 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> > Before this patch, all user specified options are silently discarded,
>>
>> The GUC settings in CREATE SUBSCRIPTION were honored up through v14;
>> the behavior changed in commit f3d4019da5d, so some might view this
>> as a regression.
>
>
> FWIW, I definitely view it as a regression. I used this in citus to make the logical replication sender of the shard rebalancer use a higher CPU priority[1]. I had no clue, until now, that that logic got completely broken in PG15 (which we coincidentally added support for in the same release).

Thanks for sharing this!

> I'm not entirely sure if it's worth a backpatch. This citus feature probably isn't the most critical. So if that's the only usecase in the wild that got broken, then that might be fine. But I at least wanted to share that others (i.e. me) have used this feature.

I found the following description in logical replication docs, which makes me
start thinking that the patch would need to be backpatched.

-----------------
If the role does not trust all table owners, include options=-crow_security=off
in the connection string
https://www.postgresql.org/docs/devel/logical-replication-security.html
-----------------

Regards,

--
Fujii Masao