Re: pgsql: Add archive_mode='always' option.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add archive_mode='always' option.
Date: 2015-05-18 06:46:53
Message-ID: CAHGQGwGZwq9MtcCccwm+7c3JiW-kaN+YKg01ReKMjU7t-1rw=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, May 16, 2015 at 12:55 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> Add archive_mode='always' option.
>
> In 'always' mode, the standby independently archives all files it receives
> from the primary.

Thanks a lot!!

- /* If we have lost the stats collector, try to start a new one */
- if (PgStatPID == 0 && pmState == PM_RUN)
- PgStatPID = pgstat_start();

Seems the above code which should exist was removed accidentally.

+ be handled similarly, but the archive_command must test if the file
+ being archived exists already, and if the existing file has identical
+ contents. This requires more care in the archive_command, as it must

Isn't it better to enclose archive_command with <varname> tags?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-05-18 07:23:41 pgsql: Put back stats-collector restarting code, removed accidentally.
Previous Message Fujii Masao 2015-05-18 05:55:24 pgsql: Don't classify REINDEX command as DDL in the pg_audit doc.