Re: pgsql: Add archive_mode='always' option.

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add archive_mode='always' option.
Date: 2015-05-18 07:24:01
Message-ID: 55599391.4050804@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 05/18/2015 09:46 AM, Fujii Masao wrote:
> On Sat, May 16, 2015 at 12:55 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> - /* If we have lost the stats collector, try to start a new one */
> - if (PgStatPID == 0 && pmState == PM_RUN)
> - PgStatPID = pgstat_start();
>
> Seems the above code which should exist was removed accidentally.

Good catch!

> + be handled similarly, but the archive_command must test if the file
> + being archived exists already, and if the existing file has identical
> + contents. This requires more care in the archive_command, as it must
>
> Isn't it better to enclose archive_command with <varname> tags?

Fixed, thanks.

- Heikki

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-05-18 07:39:25 pgsql: Fix typo in comment.
Previous Message Heikki Linnakangas 2015-05-18 07:23:41 pgsql: Put back stats-collector restarting code, removed accidentally.