Re: psql: Don't offer USING INDEX after REPACK (CONCURRENTLY) or (ANALYZE)

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
Cc: Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql: Don't offer USING INDEX after REPACK (CONCURRENTLY) or (ANALYZE)
Date: 2026-11-16 00:33:06
Message-ID: CAHGQGwGWta1-xvRh9G39BqFC7uf9UUUJ8s1ooNSLbV-5G3bthw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 16, 2026 at 3:46 AM Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:
> I'm also wondering whether the benefit
> of this completion improvement warrants a dedicated option parser for
> `REPACK`.

Agreed. While it's debatable how much server-side knowledge belongs in
tab completion, this seems like overkill to me. I'm not aware of any other
cases where we parse an option list to determine the effective settings
and use them to control subsequent completion.

I'm afraid that adding such logic could require us to keep it in sync with
server changes and handle differences between server versions. So I'm
not sure the benefit justifies the added complexity and maintenance burden.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Manu 2026-11-16 00:34:35 Re: UNDO with FILEOPS, and the FLUX table AM
Previous Message Ayoub Kazar 2026-11-16 00:27:21 Re: CREATE SCHEMA still resolves unqualified type names in pg_temp