Re: psql: Don't offer USING INDEX after REPACK (CONCURRENTLY) or (ANALYZE)

From: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
To: Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql: Don't offer USING INDEX after REPACK (CONCURRENTLY) or (ANALYZE)
Date: 2026-11-15 18:45:40
Message-ID: CAG7L5+4+_siiG4Nm-9_NgJ0sm=b9bZVkrr9z0E7QYyAmXXO=KA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Ishjaap,

I reviewed v1 on master with assertions enabled. All psql TAP tests pass.
The new tests reproduce the failure without the fix, and additional checks
for repeated options, aliases, and fallback behaviour pass with it.

The implementation looks good to me, but I'm also wondering whether the
benefit
of this completion improvement warrants a dedicated option parser for
`REPACK`.

Thanks,
Sho

--
=======================================
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2026-11-15 19:45:56 Re: CREATE SCHEMA still resolves unqualified type names in pg_temp
Previous Message Zhijie Hou 2026-11-15 17:13:15 Re: Add a hook for handling logical decoding messages on subscribers.