Re: Proposal : REINDEX xxx VERBOSE

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
Cc: Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal : REINDEX xxx VERBOSE
Date: 2015-04-08 04:09:04
Message-ID: CAHGQGwGQE4H+yB-A389mdmGYGd_0QJ5QJucOHT1BrTSGoZedNA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 8, 2015 at 1:57 AM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Wed, Apr 8, 2015 at 1:11 AM, Fabrízio de Royes Mello
> <fabriziomello(at)gmail(dot)com> wrote:
>>
>> On Tue, Apr 7, 2015 at 1:04 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
>> wrote:
>>>
>>> On Tue, Apr 7, 2015 at 10:12 PM, Fabrízio de Royes Mello
>>> <fabriziomello(at)gmail(dot)com> wrote:
>>> >
>>> > On Tue, Apr 7, 2015 at 7:22 AM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
>>> > wrote:
>>> >>
>>> >> Thank you for your reviewing.
>>> >> I modified the patch and attached latest version patch(v7).
>>> >> Please have a look it.
>>> >>
>>> >
>>> > Looks good to me. Attached patch (v8) just fix a tab indentation in
>>> > gram.y.
>>> >
>>>
>>> I had forgotten fix a tab indentation, sorry.
>>> Thank you for reviewing!
>>> It looks good to me too.
>>> Can this patch be marked as "Ready for Committer"?
>>>
>>
>> +1
>>
>
> Changed status to "Ready for Committer".

The patch adds new syntax like "REINDEX ... WITH VERBOSE", i.e., () is not
added after WITH clause. Did we reach the consensus about this syntax?
The last email from Robert just makes me think that () should be added
into the syntax.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2015-04-08 04:14:33 Removal of FORCE option in REINDEX
Previous Message Amit Kapila 2015-04-08 03:58:49 Re: Parallel Seq Scan