Re: Proposal : REINDEX xxx VERBOSE

From: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal : REINDEX xxx VERBOSE
Date: 2015-04-08 13:53:59
Message-ID: CAD21AoD7u2a1bEc03A+Y__TksZxMoKC+7BDBH=pyY=w18Poknw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 8, 2015 at 1:09 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Apr 8, 2015 at 1:57 AM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> On Wed, Apr 8, 2015 at 1:11 AM, Fabrízio de Royes Mello
>> <fabriziomello(at)gmail(dot)com> wrote:
>>>
>>> On Tue, Apr 7, 2015 at 1:04 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
>>> wrote:
>>>>
>>>> On Tue, Apr 7, 2015 at 10:12 PM, Fabrízio de Royes Mello
>>>> <fabriziomello(at)gmail(dot)com> wrote:
>>>> >
>>>> > On Tue, Apr 7, 2015 at 7:22 AM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
>>>> > wrote:
>>>> >>
>>>> >> Thank you for your reviewing.
>>>> >> I modified the patch and attached latest version patch(v7).
>>>> >> Please have a look it.
>>>> >>
>>>> >
>>>> > Looks good to me. Attached patch (v8) just fix a tab indentation in
>>>> > gram.y.
>>>> >
>>>>
>>>> I had forgotten fix a tab indentation, sorry.
>>>> Thank you for reviewing!
>>>> It looks good to me too.
>>>> Can this patch be marked as "Ready for Committer"?
>>>>
>>>
>>> +1
>>>
>>
>> Changed status to "Ready for Committer".
>
> The patch adds new syntax like "REINDEX ... WITH VERBOSE", i.e., () is not
> added after WITH clause. Did we reach the consensus about this syntax?
> The last email from Robert just makes me think that () should be added
> into the syntax.
>

Thank you for taking time for this patch!

This was quite complicated issue since we already have a lot of style
command currently.
We can think many of style from various perspective: kind of DDL, new
or old command, maintenance command. And each command has each its
story.
I believe we have reached the consensus with this style at least once
(please see previous discussion), but we might needs to discuss
more...

Regards,

-------
Sawada Masahiko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-04-08 14:02:35 Re: Tuple visibility within a single XID
Previous Message Michael Paquier 2015-04-08 12:57:07 Making src/test/ssl more robust