Re: vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ?

On Tue, Sep 16, 2025 at 10:06 PM Mircea Cadariu
<cadariu(dot)mircea(at)gmail(dot)com> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> Hi,
>
> I tested the patch with log_statement = 'all' and I confirm I do not see the VACUUM log line anymore.

Thanks for the review and testing!

> You could consider adding the following representative test in src/bin/scripts/t/100_vacuumdb.pl:
> $node->issues_sql_unlike(
> [ 'vacuumdb', '--analyze-only', 'postgres' ],
> qr/statement: VACUUM.*;/,
> 'vacuumdb --analyze-only skips vacuum');

+1. I've added that test to the patch.
Attached is the updated version of the patch.

Regards,

--
Fujii Masao