From: | Dmitry Mityugov <d(dot)mityugov(at)postgrespro(dot)ru> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: --with-llvm on 32-bit platforms? |
Date: | 2025-09-16 15:47:18 |
Message-ID: | 8e511a144293ae656daaeeccfe2f7893@postgrespro.ru |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote 2025-09-16 16:45:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>> On Tue, Sep 16, 2025 at 12:51 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
>> wrote:
>>> On Tue, Sep 16, 2025 at 12:05 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> Oh! Yeah, that is surely broken now.
>
>> This patch seems to work OK here. The deform code is a little tricky
>> as you have to think carefully about which places need TypeDatum and
>> which need TypeSizeT in llvmjit_deform.c, since the v_offp variable
>> really is size_t. Tested on Debian 13 with i386 packages installed.
>
> Thanks for doing that. It looks generally plausible to my eye,
> but I'm hardly qualified to do a detailed review.
>
>> More changes would be needed if Datum is changed into a struct.
>
> I can only imagine us doing that as a compile option to help
> catch errors. Our ambition need not reach to making the compile
> option play with --with-llvm, perhaps.
I tried the patch and it works well, thanks a lot to everyone involved
in fixing this.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2025-09-16 15:49:11 | Re: PG 18 release notes draft committed |
Previous Message | Fujii Masao | 2025-09-16 15:36:45 | Re: vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ? |