Re: Collect ALTER PUBLICATION commands for event triggers

On Fri, Jul 24, 2026 at 5:38 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> Both v1-0001 and v1-0002 look good to me.

Thanks for the review!

> While reviewing 0002, I noticed another suspicion. AlterPublicationAllFlags() directly updates the pg_publication tuple but doesn’t call InvokeObjectPostAlterHook(). This seems inconsistent with AlterPublicationOptions() and AlterPublicationOwner_internal(), which invoke that hook after altering the publication.
>
> As this is a separate issue from this patch, should I start a new thread? This seems an oversight of 493f8c6439c.

Good catch! Although it's a separate issue, I think it's fine to
discuss it here since it's a bit related and a small change.

I put together a patch to invoke the post-alter hook for
ALTER PUBLICATION SET ALL. It's attached as patch 0003
in my reply to Ian upthread.

Regards,

--
Fujii Masao