Re: Collect ALTER PUBLICATION commands for event triggers

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Collect ALTER PUBLICATION commands for event triggers
Date: 2026-07-24 13:53:04
Message-ID: CAHGQGwEscdd=UaxojkWthY8MT+JJ9-KY61QLVSfAZ02RwJiEqA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 24, 2026 at 4:45 PM Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> This seems like the kind of issue which doesn't get backpatched because
> it changes behaviour and no-one has complained about it (AFAIK),
> but that's just my Friday afternoon vibe opinion and more qualified
> opinions may be available.

Yeah, I see your point.

> Would it be an idea to add SET ALL TABLES ... EXCEPT (...) to the regression
> test as well, to clarify the expected behaviour?

Thanks for the suggestion! I've updated patch 0002 accordingly.
Attached are the updated patches.

Patch 0001 is unchanged. Patch 0003 is new and invokes the post-alter
hook for ALTER PUBLICATION SET ALL, as suggested by Chao.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v2-0001-Collect-ALTER-PUBLICATION-mapping-drops-for-event.patch application/octet-stream 12.8 KB
v2-0002-Collect-ALTER-PUBLICATION-SET-ALL-commands-for-ev.patch application/octet-stream 6.0 KB
v2-0003-Invoke-post-alter-hook-for-ALTER-PUBLICATION-SET-.patch application/octet-stream 1.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-07-24 13:54:03 Re: Collect ALTER PUBLICATION commands for event triggers
Previous Message Richard Guo 2026-07-24 13:38:05 Re: remove_useless_joins vs. bug #19560