| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add missing stats_reset column to pg_stat_database_conflicts view |
| Date: | 2026-03-13 13:25:00 |
| Message-ID: | CAHGQGwG2OpV-Z-8d9K1owosKhsDKO2kiJVvvkEzWoOMp3NzAcQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 13, 2026 at 5:47 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Mar 13, 2026, at 04:39, Sami Imseih <samimseih(at)gmail(dot)com> wrote:
> >
> >> I also made some cosmetic indentation fixes in the docs.
> >> The v6 patch is attached.
> >
> > Just one more minor comment fix I noticed.
> >
> > "Test that reset works for pg_stat_database"
> >
> > to:
> >
> > "Test that reset works for pg_stat_database and pg_stat_database_conflicts"
> >
> > --
> > Sami
> > <v7-0001-Add-stats_reset-column-to-pg_stat_database_confli.patch>
I've pushed the patch. Thanks!
> I still saw (SELECT current_database()) in v7. Does it have any special meaning than just current_database()?
No. I think it was used by the patch simply because the existing tests
for stats reset already use it.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-03-13 13:27:23 | Re: tid_blockno() and tid_offset() accessor functions |
| Previous Message | Peter Eisentraut | 2026-03-13 13:23:50 | Re: Add --extra-dependencies and immediate data dumping for pg_dump/pg_upgrade |